reuvenlax commented on issue #11034: [BEAM-9424] Allow grouping by LogicalType URL: https://github.com/apache/beam/pull/11034#issuecomment-594651288 @kanterov ok, I see the bug now. the problem is because we have an unfortunate asymmetry between Row.Builder.addValues and Row.getValues. getValues returns the base type for logical types (because that's how it's stored, but addValues expects to get the input type. I'm still thinking of the best way to resolve this inconsistency without breaking other use cases. However a simple fix for now is to fix SelectHelpers to use attachValues instead of addValues. Coincidentally that change is already made in https://github.com/apache/beam/pull/11025. Can you check to see whether that PR fixes the problem you're seeing?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
