rohdesamuel commented on a change in pull request #11005: [BEAM-8335] Modify the StreamingCache to subclass the CacheManager URL: https://github.com/apache/beam/pull/11005#discussion_r388009717
########## File path: sdks/python/apache_beam/runners/interactive/caching/streaming_cache.py ########## @@ -19,15 +19,298 @@ from __future__ import absolute_import +import itertools +import os +import shutil +import tempfile +import time + +import apache_beam as beam +from apache_beam.portability.api.beam_interactive_api_pb2 import TestStreamFileHeader +from apache_beam.portability.api.beam_interactive_api_pb2 import TestStreamFileRecord from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload +from apache_beam.runners.interactive.cache_manager import CacheManager +from apache_beam.runners.interactive.cache_manager import SafeFastPrimitivesCoder +from apache_beam.testing.test_stream import ReverseTestStream from apache_beam.utils import timestamp -class StreamingCache(object): +class StreamingCacheSink(beam.PTransform): + """A PTransform that writes TestStreamFile(Header|Records)s to file. + + This transform takes in an arbitrary element stream and writes the best-effort Review comment: Clarified in the comment that it is best-effort replay not best-effort writing. The original comment was confusing. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
