robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the
StreamingCache to subclass the CacheManager
URL: https://github.com/apache/beam/pull/11005#discussion_r389117616
##########
File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
##########
@@ -421,8 +440,12 @@ def process_element(self, element):
main_output = list(self._outputs)[0]
bundle = self._evaluation_context.create_bundle(main_output)
for tv in event.timestamped_values:
- bundle.output(
- GlobalWindows.windowed_value(tv.value, timestamp=tv.timestamp))
+ # Unreify the value into the correct window.
+ try:
+ bundle.output(WindowedValue(**tv.value))
Review comment:
In that case, it'd be cleaner to make a new class WindowedValueHolder, or
use a 1-tuple of WindowedValue, or something explicit like that rather than
trying to use every element as kwargs to WindowedValue constructor and falling
back otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
