robertwb commented on a change in pull request #11005: [BEAM-8335] Modify the 
StreamingCache to subclass the CacheManager 
URL: https://github.com/apache/beam/pull/11005#discussion_r389129387
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py
 ##########
 @@ -214,11 +214,31 @@ class _TestStreamRootBundleProvider(RootBundleProvider):
   """
   def get_root_bundles(self):
     test_stream = self._applied_ptransform.transform
+
+    # The TestStream specification allows for multiple TestStreams in the same
 
 Review comment:
   No, there should only be one TestStream per pipeline. That's the reason we 
introduced test streams with multiple outputs. (I also fail to see how multiple 
TestStreams would work, as they would all seem to share the same global context 
and so it seems all test stream evaluators would emit all events). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to