zymap commented on code in PR #3658:
URL: https://github.com/apache/bookkeeper/pull/3658#discussion_r1027595511
##########
RELEASING.md:
##########
@@ -0,0 +1,35 @@
+# Bookkeeper release guide
+
+## Docker
Review Comment:
Maybe we can move this doc under the docker directory?
##########
RELEASING.md:
##########
@@ -0,0 +1,35 @@
+# Bookkeeper release guide
Review Comment:
```suggestion
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
# Bookkeeper release guide
```
##########
docker/hooks/build:
##########
@@ -1,9 +1,6 @@
#!/bin/bash
set -x
-# When we build 'latest' tag we want to not override BK_VERSION variable
-if [[ "$DOCKER_TAG" = "latest" ]]
-then
- docker build -t $IMAGE_NAME .
-else
- docker build --build-arg BK_VERSION=$DOCKER_TAG -t $IMAGE_NAME .
-fi
+
+BK_RELEASE_VERSION=`curl --silent
https://api.github.com/repos/apache/bookkeeper/releases/latest | jq '.tag_name'
| sed "s/\"release-\([0-9.]*\).*/\1/"`
+
+docker build --build-arg BK_VERSION=$BK_RELEASE_VERSION -t $IMAGE_NAME .
Review Comment:
We also use to build the branch, we shouldn't always use the latest release
as the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
