zymap commented on code in PR #3658: URL: https://github.com/apache/bookkeeper/pull/3658#discussion_r1028778196
########## docker/hooks/build: ########## @@ -1,9 +1,13 @@ #!/bin/bash set -x -# When we build 'latest' tag we want to not override BK_VERSION variable +# When we build 'latest' tag we want always get the latest released version + if [[ "$DOCKER_TAG" = "latest" ]] then - docker build -t $IMAGE_NAME . + # GH API currently returns tags in the order they would be returned by the "git tag" command, which means they are alphabetically sorted. + # BK_RELEASE_VERSION points to the "highest" released version + BK_RELEASE_VERSION=`curl -s https://api.github.com/repos/apache/bookkeeper/tags | jq -r '.[0].name' | sed 's/release-\([0-9.]*\).*/\1/'` + docker build --build-arg BK_VERSION=$BK_RELEASE_VERSION -t $IMAGE_NAME:$BK_RELEASE_VERSION . Review Comment: ```suggestion docker build --build-arg BK_VERSION=$BK_RELEASE_VERSION -t $IMAGE_NAME . ``` IMAGE_NAME contains the tag and repo name. We just need to give it the latest release version, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
