tomaszmichalak commented on code in PR #3658:
URL: https://github.com/apache/bookkeeper/pull/3658#discussion_r1027766156


##########
docker/hooks/build:
##########
@@ -1,9 +1,6 @@
 #!/bin/bash
 set -x
-# When we build 'latest' tag we want to not override BK_VERSION variable
-if [[ "$DOCKER_TAG" = "latest" ]]
-then
-  docker build -t $IMAGE_NAME .
-else
-  docker build --build-arg BK_VERSION=$DOCKER_TAG -t $IMAGE_NAME .
-fi
+
+BK_RELEASE_VERSION=`curl --silent 
https://api.github.com/repos/apache/bookkeeper/releases/latest | jq '.tag_name' 
| sed "s/\"release-\([0-9.]*\).*/\1/"`
+
+docker build --build-arg BK_VERSION=$BK_RELEASE_VERSION -t $IMAGE_NAME .

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to