eolivelli commented on code in PR #4171:
URL: https://github.com/apache/bookkeeper/pull/4171#discussion_r1448521452
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -1811,12 +1813,17 @@ void sendAddSuccessCallbacks() {
// entries that have had all their responses come back
PendingAddOp pendingAddOp;
+ if (!sendingCallbacks.compareAndSet(false, true)) {
Review Comment:
This method is always called by the same thread, we don't need this logic,
this is thanks to the usage of an OrderedExecutor, that is used using the
ledgerId as key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
