eolivelli commented on code in PR #4171:
URL: https://github.com/apache/bookkeeper/pull/4171#discussion_r1448540352
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -1811,12 +1813,17 @@ void sendAddSuccessCallbacks() {
// entries that have had all their responses come back
PendingAddOp pendingAddOp;
+ if (!sendingCallbacks.compareAndSet(false, true)) {
Review Comment:
it must always be called using the OrderedExecutor, the fix should go in the
direction of using the OrderedExecutor
maybe you can add a “safeSendAddSuccessCallbacks” that calls
sendAddSuccessCallbacks in the OrderedExecutor
(maybe a better name?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
