lhotari commented on code in PR #4171:
URL: https://github.com/apache/bookkeeper/pull/4171#discussion_r1448682604
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java:
##########
@@ -1811,12 +1813,17 @@ void sendAddSuccessCallbacks() {
// entries that have had all their responses come back
PendingAddOp pendingAddOp;
+ if (!sendingCallbacks.compareAndSet(false, true)) {
Review Comment:
It looks like OrderedExecutor isn't used in most of the current usages. It
would be a major change to change the way how callbacks are executed and it
possibly wouldn't solve the problem. It looks like `pendingAddsSequenceHead`
gets out of sync in `drainPendingAddsAndAdjustLength` method and that might be
the root cause. Could you please check these suggestions:
https://github.com/apache/bookkeeper/pull/4171#issuecomment-1886869318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
