AnonHxy commented on code in PR #4199:
URL: https://github.com/apache/bookkeeper/pull/4199#discussion_r1479275766
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -105,9 +105,7 @@ protected void processPacket() {
}
errorCode = BookieProtocol.ENOENTRY;
} catch (IOException e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Error reading {}", request, e);
- }
+ LOG.error("IOException while reading {}", request, e);
Review Comment:
> whole stack trace every time a client gets a connectivity error with any
bookie
Thanks for your review @merlimat . But I don't get your point. This method
runs only on serever side and probability throw `IOException` if read an entry
from storage. So I think it doesn't matter with client print logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
