AnonHxy commented on code in PR #4199:
URL: https://github.com/apache/bookkeeper/pull/4199#discussion_r1499485709
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -105,9 +105,7 @@ protected void processPacket() {
}
errorCode = BookieProtocol.ENOENTRY;
} catch (IOException e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Error reading {}", request, e);
- }
+ LOG.error("IOException while reading {}", request, e);
Review Comment:
I think print whole `request ` is OK. because `ReadRequest` has overwrite
the `toString` method:
https://github.com/apache/bookkeeper/blob/34bd4b38fa13f105608ae4e7b4c749124c271e1e/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieProtocol.java#L249-L251
@hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
