horizonzy commented on code in PR #4199:
URL: https://github.com/apache/bookkeeper/pull/4199#discussion_r1527767782
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java:
##########
@@ -105,9 +105,7 @@ protected void processPacket() {
}
errorCode = BookieProtocol.ENOENTRY;
} catch (IOException e) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Error reading {}", request, e);
- }
+ LOG.error("IOException while reading {}", request, e);
Review Comment:
> > I believe this would print the whole stack trace every time a client
gets a connectivity error with any bookie, for each entry that we're trying to
read.
>
> If the target entry does not exist on the bookie, it will throw
NoLedgerException or NoEntryException and won't go into this code path.
@merlimat Do you have any concern?
The NoLedgerException and NoEntryException extend IOException, it should be
caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
