StevenLuMT commented on code in PR #4706:
URL: https://github.com/apache/bookkeeper/pull/4706#discussion_r2725991852
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##########
@@ -67,7 +70,19 @@ public EntryLocationIndex(ServerConfiguration conf,
KeyValueStorageFactory stora
@Override
public void close() throws IOException {
+ log.info("Closing EntryLocationIndex");
+ while (!compacting.compareAndSet(false, true)) {
Review Comment:
This waiting could result in the system being stuck here indefinitely, or it
could take an exceptionally long time to get stuck at this step.
Should we add a maximum waiting time, or do something else, such as
modifying RocksDB operations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
