StevenLuMT commented on code in PR #4706:
URL: https://github.com/apache/bookkeeper/pull/4706#discussion_r2725994031


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##########
@@ -203,15 +218,17 @@ public String getEntryLocationDBPath() {
 
     public void compact() throws IOException {
         try {
-            isCompacting = true;
+            if (!compacting.compareAndSet(false, true)) {

Review Comment:
   I have a question:
   
   Is the `isCompacting` syntax the root cause of this problem?
   Or is it simply a matter of rewriting the method more efficiently, thus 
ruling out issues with the `isCompacting` setting?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to