AnonHxy commented on code in PR #4706:
URL: https://github.com/apache/bookkeeper/pull/4706#discussion_r2728177764
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java:
##########
@@ -67,7 +70,19 @@ public EntryLocationIndex(ServerConfiguration conf,
KeyValueStorageFactory stora
@Override
public void close() throws IOException {
+ log.info("Closing EntryLocationIndex");
+ while (!compacting.compareAndSet(false, true)) {
Review Comment:
I dont think so. Closing a DB which in compaction status may triger core
dumps or other unexpected error. If Closing the DB cost toot long time, I
think we'd better find out why or `kill -9` if we need.
The handling approach here is similar to the procedure below：
https://github.com/apache/bookkeeper/blob/3a5cf9d2fb35c758e804855ac30ad0044ee983a4/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java#L770-L772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
