AdrianVovk commented on issue #44: URL: https://github.com/apache/buildstream-plugins/issues/44#issuecomment-1672044014
> It is perfectly fine to expect an element has to be tracked at least once and outputs committed into git for it to be buildable. However, refs stored in git must be sufficient for instrumenting source fetching and building. I see how my working could have been confusing. I meant that if you just generate the Cargo.lock file (and store it in the mirror dir) during tracking (and commit the resulting `project.refs` file), someone on the other side wouldn't be able to build since they wouldn't have a Cargo.lock file to stage. As you say, refs stored in git must be sufficient to fetch and build. > I would suggesting making proposal in the form of a PR :+1: > I would really love to have tests added for cargo plugin as well in the same go, it currently has none making any changes to it very dangerous. What do you expect such a test to look like? A project that junctions off freedesktop-sdk to get a working `cargo`, then tracks, compiles, and runs some hello-world rust project? How do we find out if the cache key changed? Hard-code it into the test and have to manually update it w/ major buildstream updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
