gtristan commented on issue #44: URL: https://github.com/apache/buildstream-plugins/issues/44#issuecomment-1672495298
> I don't think I still get it. Do you or do you not need a Cargo.lock in build sandbox to build the project? This is indeed the question. Also the question is whether *some* projects require the `Cargo.lock` at build time while others do not, and whether upstream will potentially *change* one day such as to *start requiring the `Cargo.lock`* at build time. The uncertainty around these details leads me to intuit that it would be safer and simpler to just have a separate `cargo-generate-lock` plugin which serializes the `Cargo.lock` data into its `ref`. As a side note, we would probably want such a lock generating plugin to only call `utils.get_host_tool()` directly in `Source.track()` rather than in `Plugin.preflight()`, this will fail a bit later than usual when lacking host `cargo` but will not require host `cargo` to build unless you run `bst source track`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
