nanonyme commented on issue #44:
URL: 
https://github.com/apache/buildstream-plugins/issues/44#issuecomment-1672172463

   > > It is perfectly fine to expect an element has to be tracked at least 
once and outputs committed into git for it to be buildable. However, refs 
stored in git must be sufficient for instrumenting source fetching and building.
   > 
   > I see how my working could have been confusing. I meant that if you just 
generate the Cargo.lock file (and store it in the mirror dir) during tracking 
(and commit the resulting `project.refs` file), someone on the other side 
wouldn't be able to build since they wouldn't have a Cargo.lock file to stage. 
As you say, refs stored in git must be sufficient to fetch and build.
   
   I don't think I still get it. Do you or do you not need a Cargo.lock to 
build a project in addition to the ref that cargo plugin creates? Or are you 
intending to change the ref format for cargo plugin? Because current ref format 
seems to me to be insufficient for recreating a Cargo.lock.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to