nanonyme commented on code in PR #1879:
URL: https://github.com/apache/buildstream/pull/1879#discussion_r1389096388
##########
src/buildstream/_remotespec.py:
##########
@@ -253,6 +266,10 @@ def new_from_node(
if auth_node:
server_cert, client_key, client_cert = cls._parse_auth(auth_node,
basedir)
+ keepalive_config = spec_node.get_mapping("keepalive-config", None)
+ if keepalive_config is not None:
+ keepalive_config.validate_keys(["keepalive-time"])
Review Comment:
This was suggestion by @juergbi if I understood right. There are about ten
keepalive settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
