nanonyme commented on code in PR #1879:
URL: https://github.com/apache/buildstream/pull/1879#discussion_r1424499867
##########
src/buildstream/_remotespec.py:
##########
@@ -112,6 +113,9 @@ def __init__(
# The grpc credentials object
self._credentials: Optional[ChannelCredentials] = None
+ # Various connection parameters for grpc connection
+ self._connection_config: Optional[int] = connection_config
Review Comment:
You are right, if this is set in project config, then it clearly needs a
version bump. I was assuming (perhaps incorrectly) that the most useful way to
use this is through user config where you override project CAS with your own
config and set timeout there if you're having connection issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
