nanonyme commented on code in PR #1879:
URL: https://github.com/apache/buildstream/pull/1879#discussion_r1424509271
##########
src/buildstream/_remotespec.py:
##########
@@ -176,6 +181,13 @@ def credentials(self) -> ChannelCredentials:
)
return self._credentials
+ # grpc keepalive timeout
+ #
+ @property
+ def keepalive_time(self) -> Optional[int]:
+ if self._connection_config:
+ return self._connection_config.get_int("keepalive-timeout", None)
Review Comment:
Should this say keepalive time or timeout? I know the problem I currently
have is being inconsistent. https://grpc.io/docs/guides/keepalive/ talks of
keepalive timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
