juergbi commented on code in PR #60:
URL:
https://github.com/apache/buildstream-plugins/pull/60#discussion_r1524622229
##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -234,9 +233,8 @@ def _download(self, url):
# (str): The URL for this crate
#
def _get_url(self, alias=None):
- url = self.cargo.translate_url(self.cargo.url, alias_override=alias)
path = "{name}/{name}-{version}.crate".format(name=self.name,
version=self.version)
- return urljoin(f"{url}/", path)
+ return self.cargo.translate_url(self.cargo.url, suffix=path,
alias_override=alias)
Review Comment:
Requiring aliases to end with a trailing slash does sound sensible, although
I'm not sure whether this is a concern with regards to backward compatibility.
We also need to update the default URL in `configure()` and the doc comment.
And update `BST_MIN_VERSION` to `2.2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
