abderrahim commented on code in PR #60:
URL:
https://github.com/apache/buildstream-plugins/pull/60#discussion_r1524701681
##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -234,9 +233,8 @@ def _download(self, url):
# (str): The URL for this crate
#
def _get_url(self, alias=None):
- url = self.cargo.translate_url(self.cargo.url, alias_override=alias)
path = "{name}/{name}-{version}.crate".format(name=self.name,
version=self.version)
- return urljoin(f"{url}/", path)
+ return self.cargo.translate_url(self.cargo.url, suffix=path,
alias_override=alias)
Review Comment:
Updated, thanks.
Regarding `BST_MIN_VERSION`, I didn't update it because until 2.2 is
released it wouldn't work on buildstream. I'm not sure what's the best way to
do it, but we might want to delay merging this until 2.2 is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
