gtristan commented on code in PR #60:
URL:
https://github.com/apache/buildstream-plugins/pull/60#discussion_r1551736078
##########
src/buildstream_plugins/sources/cargo.py:
##########
@@ -35,8 +35,8 @@
# Specify the cargo source kind
kind: cargo
- # Url of the crates repository to download from (default:
https://static.crates.io/crates)
- url: https://static.crates.io/crates
+ # Url of the crates repository to download from (default:
https://static.crates.io/crates/)
+ url: https://static.crates.io/crates/
Review Comment:
I don't think this change is legal.
This will be extracted as `self.url` which will be considered in
`self.get_unique_key()`, so this change breaks cache keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
