doraskayo commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2666555597
##########
src/buildstream/source.py:
##########
@@ -642,10 +690,22 @@ def serialize(self) -> Dict[str, Union[str, Dict[str,
str]]]:
"url": self.url,
}
- if self.homepage is not None:
- version_info["homepage"] = self.homepage
- if self.issue_tracker is not None:
- version_info["issue-tracker"] = self.issue_tracker
+ source_info_extra_fields = [
+ "concluded-license",
+ "copyright-text",
+ "declared-license",
+ "description",
+ "external-reference",
+ "homepage",
+ "issue-tracker",
+ "name",
+ "originator",
+ "supplier",
+ ]
Review Comment:
Can we get the user-configurable `provenance` attribute documented here, and
also exactly which fields we allow specifying in it including those introduced
by this PR?
https://github.com/apache/buildstream/blob/86a950aba52ef6aa2cb868bf13fb24e20de37679/doc/source/format_declaring.rst#sources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
