joshua-zivkovic commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2667416311
##########
src/buildstream/source.py:
##########
@@ -642,10 +690,22 @@ def serialize(self) -> Dict[str, Union[str, Dict[str,
str]]]:
"url": self.url,
}
- if self.homepage is not None:
- version_info["homepage"] = self.homepage
- if self.issue_tracker is not None:
- version_info["issue-tracker"] = self.issue_tracker
+ source_info_extra_fields = [
+ "concluded-license",
+ "copyright-text",
+ "declared-license",
+ "description",
+ "external-reference",
+ "homepage",
+ "issue-tracker",
+ "name",
+ "originator",
+ "supplier",
+ ]
Review Comment:
This is all going to be implemented in a different way now that removes the
requirement for the buildstream core to have to know about all this SBOM stuff
that is irrelevant to it. Instead
[buildstream-sbom](https://gitlab.com/BuildStream/buildstream-sbom) will be
used for storing this as a source of truth and allowing for the buildstream
core to not get cluttered up with this.
I am currently working on a new set of patches to implement this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
