juergbi commented on code in PR #2160:
URL: https://github.com/apache/buildstream/pull/2160#discussion_r3705698275
##########
src/buildstream/_cas/casremote.py:
##########
@@ -92,7 +94,16 @@ def send(self, *, missing_blobs=None):
local_cas = self._remote.casd.get_local_cas()
for request in self._requests:
- batch_response = local_cas.FetchMissingBlobs(request)
+ batch_response_future = local_cas.FetchMissingBlobs.future(request)
+
+ try:
+ while batch_response_future.running():
+ time.sleep(1)
Review Comment:
The updated version may not be more elegant but it should be slightly more
efficient.
I think a helper function would make sense. If we don't need it beyond these
two gRPC calls, I wouldn't consider it essential but if it's straight forward,
why not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
