abderrahim commented on code in PR #2160:
URL: https://github.com/apache/buildstream/pull/2160#discussion_r3719872363
##########
src/buildstream/_cas/casremote.py:
##########
@@ -92,7 +94,16 @@ def send(self, *, missing_blobs=None):
local_cas = self._remote.casd.get_local_cas()
for request in self._requests:
- batch_response = local_cas.FetchMissingBlobs(request)
+ batch_response_future = local_cas.FetchMissingBlobs.future(request)
+
+ try:
+ while batch_response_future.running():
+ time.sleep(1)
Review Comment:
I didn't know `FindMissingBlobs` could upload blobs to the remote, that's
why I skipped it along with the remote asset calls (which should be indeed
pretty fast). I changed `FindMissingBlobs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
