juergbi commented on code in PR #2160:
URL: https://github.com/apache/buildstream/pull/2160#discussion_r3706020895
##########
src/buildstream/_cas/casremote.py:
##########
@@ -92,7 +94,16 @@ def send(self, *, missing_blobs=None):
local_cas = self._remote.casd.get_local_cas()
for request in self._requests:
- batch_response = local_cas.FetchMissingBlobs(request)
+ batch_response_future = local_cas.FetchMissingBlobs.future(request)
+
+ try:
+ while batch_response_future.running():
+ time.sleep(1)
Review Comment:
> We could also do the same to the FetchTree calls in cascache.py
Yes, I think we should apply this change also to `FetchTree` in
`fetch_directory()` and `FindMissingBlobs` in `missing_blobs()`. This should
cover all gRPC calls involving ordinary remotes (i.e., everything except
`storage-service`). To also cover `storage-service`, we might have to apply it
to practically all gRPC calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
