abderrahim commented on code in PR #2174:
URL: https://github.com/apache/buildstream/pull/2174#discussion_r3913153362
##########
src/buildstream/_stream.py:
##########
@@ -844,7 +844,8 @@ def artifact_log(self, targets):
self._context.messenger.warn("{} is cached without log
files".format(ref))
continue
- artifact_logs[obj.name] = obj._get_logs()
+ name = ref if isinstance(obj, ArtifactElement) else
obj._get_full_name()
Review Comment:
I think it makes more sense to set the `name` in ArtifactElement (you can
set it before chaining up to the super class `__init__()` so that it gets
picked up). I feel it would be more elegant than trying to override
`_get_full_name()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
