zabetak commented on a change in pull request #1104: [CALCITE-2900]
RewriteRexShuttle generates wrong type during flatten for structured type when
visitInputRef
URL: https://github.com/apache/calcite/pull/1104#discussion_r265886455
##########
File path: core/src/test/java/org/apache/calcite/tools/PlannerTest.java
##########
@@ -996,6 +997,66 @@ private void checkBushy(String sql, String expected)
throws Exception {
assertThat(toString(transform), containsString(expected));
}
+ private void checkFlattenTypesOnNestedColumn(String sql, String expected)
throws Exception {
Review comment:
As fas as I can see the method only checks that the query has the expected
plan and has nothing specific with type checking or nested columns. I think the
name is a bit confusing and should be changed. Moreover I see the method
checkBushy just above and I can see that there is a good part of code that is
repeated. It would be good to refactor a bit the two methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
