zabetak commented on a change in pull request #1104: [CALCITE-2900]
RewriteRexShuttle generates wrong type during flatten for structured type when
visitInputRef
URL: https://github.com/apache/calcite/pull/1104#discussion_r266773528
##########
File path:
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##########
@@ -2559,6 +2559,18 @@ public void testDynamicStarInTableJoin() throws
Exception {
sql(sql).with(getTesterWithDynamicTable()).ok();
}
+ /**
+ * Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-2900";>[CALCITE-2900]
+ * RewriteRexShuttle generates wrong type during flatten for structured type
when
+ * visitInputRef</a>.
+ */
+ @Test
+ public void testNestedColumn() {
Review comment:
SqlToRelConverterTest is a good place. Actually it seems that you can move
all the tests here. Moreover this new test does not bring something significant
in comparison with the previous ones so I would suggest to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
