zabetak commented on a change in pull request #1104: [CALCITE-2900] 
RewriteRexShuttle generates wrong type during flatten for structured type when 
visitInputRef
URL: https://github.com/apache/calcite/pull/1104#discussion_r268369911
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/catalog/Fixture.java
 ##########
 @@ -109,16 +109,23 @@
             .build();
     empListType =
         typeFactory.createArrayType(empRecordType, -1);
+
+    // Subclass ObjectSqlType to make nested field queryable.
     addressType =
-        new ObjectSqlType(SqlTypeName.STRUCTURED,
+        new ObjectSqlType(
+            SqlTypeName.STRUCTURED,
 
 Review comment:
   Thanks for your detailed explanation @my7ym! Indeed, I was not expecting it 
to be so complicated. I agree with you, probably the best place is 
SqlToRelConverterTest and there is no need to touch the Bookstore schema.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to