my7ym commented on a change in pull request #1104: [CALCITE-2900]
RewriteRexShuttle generates wrong type during flatten for structured type when
visitInputRef
URL: https://github.com/apache/calcite/pull/1104#discussion_r266269443
##########
File path: core/src/test/java/org/apache/calcite/test/BookstoreSchema.java
##########
@@ -90,16 +96,50 @@ public Author(int aid, String name, Place birthPlace,
List<Book> books) {
/**
*/
public static class Place {
- public final Coordinate coords;
public final String city;
public final String country;
+ public final double elevationInMeters;
+ public final Coordinate coords;
+ public final Area area;
Review comment:
I tested against elevationInMeters and Area.number.
The reason why they are necessary because the targeted type has to be
different than the first field's type of the current level. Here,
elevationInMeters type has to be different than city, and area.number has to be
different than areaUnit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
