my7ym commented on a change in pull request #1104: [CALCITE-2900]
RewriteRexShuttle generates wrong type during flatten for structured type when
visitInputRef
URL: https://github.com/apache/calcite/pull/1104#discussion_r266295739
##########
File path:
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##########
@@ -2559,6 +2559,18 @@ public void testDynamicStarInTableJoin() throws
Exception {
sql(sql).with(getTesterWithDynamicTable()).ok();
}
+ /**
+ * Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-2900";>[CALCITE-2900]
+ * RewriteRexShuttle generates wrong type during flatten for structured type
when
+ * visitInputRef</a>.
+ */
+ @Test
+ public void testNestedColumn() {
Review comment:
@zabetak This is the new a little "low-level" test I added.
SqlToRelConverter.flattenTypes is almost the lowest level entry point for this
test. The other option is RelStructuredTypeFlattener.rewrite. But for this
test, I have to write a lot of boilerplate code for this single test. Since
there is almost no extra logic applied in SqlToRelConverter.flattenTypes, I
think it should be OK.
Let me know. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
