my7ym commented on a change in pull request #1104: [CALCITE-2900] 
RewriteRexShuttle generates wrong type during flatten for structured type when 
visitInputRef
URL: https://github.com/apache/calcite/pull/1104#discussion_r268348408
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/catalog/Fixture.java
 ##########
 @@ -109,16 +109,23 @@
             .build();
     empListType =
         typeFactory.createArrayType(empRecordType, -1);
+
+    // Subclass ObjectSqlType to make nested field queryable.
     addressType =
-        new ObjectSqlType(SqlTypeName.STRUCTURED,
+        new ObjectSqlType(
+            SqlTypeName.STRUCTURED,
 
 Review comment:
   @zabetak And if you think OK, we could just keep the existing 
second-level-access test I implemented in SqlToRelConverterTest. I don't think 
there is much difference between the second level and the third level.
   
   If so, I will delete all changes made to Bookstore and PlannerTest.
   
   let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to