hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r280252142
##########
File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java
##########
@@ -659,15 +736,12 @@ public static Double getJoinRowCount(RelMetadataQuery
mq, Join join,
}
double product = left * right;
- // TODO: correlation factor
return product * mq.getSelectivity(join, condition);
}
/** Returns an estimate of the number of rows returned by a
* {@link SemiJoin}. */
- public static Double getSemiJoinRowCount(RelMetadataQuery mq, RelNode left,
- RelNode right, JoinRelType joinType, RexNode condition) {
- // TODO: correlation factor
+ public static Double getSemiJoinRowCount(RelMetadataQuery mq, RelNode left,
RexNode condition) {
Review comment:
Why do you change the function signature? The right and joinType is not used
for now, but doesn't mean we don't use it in the future. The current
implementation is pretty naive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
