hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r285230725
##########
File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java
##########
@@ -400,13 +398,16 @@ public RelNode createCorrelate(RelNode left, RelNode
right,
/**
* Implementation of {@link SemiJoinFactory} that returns a vanilla
* {@link SemiJoin}.
+ *
+ * @deprecated Use {@link JoinFactoryImpl} instead.
*/
+ @Deprecated // to be removed before 2.0
private static class SemiJoinFactoryImpl implements SemiJoinFactory {
public RelNode createSemiJoin(RelNode left, RelNode right,
- RexNode condition) {
+ RexNode condition) {
final JoinInfo joinInfo = JoinInfo.of(left, right, condition);
return SemiJoin.create(left, right,
- condition, joinInfo.leftKeys, joinInfo.rightKeys);
+ condition, joinInfo.leftKeys, joinInfo.rightKeys);
Review comment:
and here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
