rubenada commented on a change in pull request #1246: [CALCITE-2968] New
AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#discussion_r291071652
##########
File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
##########
@@ -152,7 +153,7 @@ public JoinRelType cancelNullsOnRight() {
}
/** Transform this JoinRelType to CorrelateJoinType. **/
- public CorrelateJoinType toLinq4j() {
+ public CorrelateJoinType toLinq4jCorrelateJoinType() {
Review comment:
If we decide to deprecate `CorrelateJoinType`, I'd rather keep this method
unchanged for the moment, and mark it as deprecated at the same time that we
deprecate `CorrelateJoinType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
