rubenada commented on a change in pull request #1246: [CALCITE-2968] New
AntiJoin relational expression
URL: https://github.com/apache/calcite/pull/1246#discussion_r291074003
##########
File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java
##########
@@ -167,19 +168,28 @@ public CorrelateJoinType toLinq4j() {
"Unable to convert " + this + " to CorrelateJoinType");
}
- public boolean projectsRight() {
+ /** Transform this JoinRelType to Linq4j JoinType. **/
+ public JoinType toLinq4jJoinType() {
Review comment:
I think that rather sooner than later another some other class apart from
EnumerableNestedLoopJoin will need this method (starting with
EnumerableCorrelate if/when we deprecate CorrelateJoinType). But I'm not
against moving this method into EnumerableNestedLoopJoin for the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
