rubenada commented on a change in pull request #1246: [CALCITE-2968] New AntiJoin relational expression URL: https://github.com/apache/calcite/pull/1246#discussion_r291071051
########## File path: linq4j/src/main/java/org/apache/calcite/linq4j/JoinType.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.linq4j; + +/** + * Enumeration of join types. + */ +public enum JoinType { Review comment: I agree, I think we should deprecate CorrelateJoinType and use the new JoinType everywhere in Linq4j (although we would need to add some checks to verify that the places expecting a "correlate" type do not get an illegal value: RIGHT / FULL). IMHO this refactoring should be done in a separate patch. Looking at the code, it seems that CorrelateJoinType is not that widely used, so it could be feasible for 1.20. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
