wenhuitang edited a comment on issue #1257: [CALCITE-3115] Add JdbcRules which have different JdbcConvention to same VolcanoPlanner's RuleSet URL: https://github.com/apache/calcite/pull/1257#issuecomment-503550011 > Good work @wenhuitang, just a few minor things that may be worth considering! Hello, @zabetak , thanks for your reviews. I have addressed the test case. As for the JdbcConvention#toString(), it returns the name of the Convention which is "JDBC." + name. And the name is specified when creating a JdbcSchema. So it maybe not obey the description pattern of the rule. As far as I know, the description of JdbcToEnumerableConverterRule is "JdbcToEnumerableConverterRule:" + out too. To solve this problem, I add a unique signature which obey the description pattern of the rule in JdbcConvention and override JdbcConvention#toString to get this signature.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
