danny0405 commented on a change in pull request #1271: [CALCITE-3112]Support 
Window in RelToSqlConverter
URL: https://github.com/apache/calcite/pull/1271#discussion_r294779249
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
 ##########
 @@ -645,6 +647,54 @@ public SqlNode toSql(RexProgram program, RexNode rex) {
       }
     }
 
+    public List<SqlNode> toSql(Window.Group group, ImmutableList<RexLiteral> 
constants,
+                               int inputFieldCount) {
 
 Review comment:
   nit: fix the indent.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to