danny0405 commented on a change in pull request #1475: [CALCITE-3371]
BinaryExpression evaluate method support Mod
URL: https://github.com/apache/calcite/pull/1475#discussion_r329343981
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/tree/BinaryExpression.java
##########
@@ -99,6 +99,29 @@ public Object evaluate(Evaluator evaluator) {
default:
throw cannotEvaluate();
}
+ case Mod:
+ switch (primitive) {
Review comment:
You may also define the reference in RexImpTable[1].
[1]
https://github.com/apache/calcite/blob/2dc97e6723e1b5bf762540f87ffffb5cd1a848a1/core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java#L338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
