danny0405 commented on a change in pull request #1475: [CALCITE-3371]
BinaryExpression evaluate method support Mod
URL: https://github.com/apache/calcite/pull/1475#discussion_r335835953
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -345,6 +346,7 @@
defineBinary(PLUS, Add, NullPolicy.STRICT, "plus");
defineBinary(MINUS, Subtract, NullPolicy.STRICT, "minus");
defineBinary(MULTIPLY, Multiply, NullPolicy.STRICT, "multiply");
+ defineBinary(MOD, Mod, NullPolicy.STRICT, "mod");
defineBinary(DIVIDE, Divide, NullPolicy.STRICT, "divide");
Review comment:
Oops, there is already a `MOD` implementation as the method call [1], so
this patch is not necessary, sorry for that.
[1]
https://github.com/apache/calcite/blob/2ac44153c4a521694c4dc975dd37b097184fc998/core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java#L353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
