danny0405 commented on a change in pull request #1475: [CALCITE-3371]
BinaryExpression evaluate method support Mod
URL: https://github.com/apache/calcite/pull/1475#discussion_r335835143
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java
##########
@@ -191,6 +191,7 @@ public boolean isBangEqualAllowed() {
@Override public boolean isPercentRemainderAllowed() {
switch (this) {
+ case DEFAULT:
case BABEL:
Review comment:
You have changed the default behavior of `%` in SQL, can you give the reason
? Is it follows the SQL standard ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
