amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped
Window Function TUMBLE should return "$TUMBLE"…
URL: https://github.com/apache/calcite/pull/1510#discussion_r336117558
##########
File path:
core/src/main/java/org/apache/calcite/sql/SqlGroupedWindowFunction.java
##########
@@ -128,13 +128,6 @@ public SqlGroupedWindowFunction auxiliary(String name,
SqlKind kind) {
// make the method abstract.
return call.getOperandMonotonicity(0).unstrict();
}
-
- @Override public String getName() {
- // Always rename the name of the SqlKind. The tumble operator is called
- // "$TUMBLE", so that it does not clash with a user-defined table function
- // "TUMBLE", but we want the name to be "TUMBLE".
- return getKind().name();
- }
Review comment:
Yes Danny. That was the old design to return "TUMBLE" as operator name.
It turns out the old design didn't fully solve function overloading problem
(grouped TUMBLE and table value function TUMBLE). I discussed it with Julian in
[1], and Julian recommended to return "$TUMBLE" directly as the function name.
Please check the last two comments of [1].
[1]: https://jira.apache.org/jira/browse/CALCITE-3382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
