amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped
Window Function TUMBLE should return "$TUMBLE"…
URL: https://github.com/apache/calcite/pull/1510#discussion_r339401555
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -10093,22 +10093,22 @@ private void checkCustomColumnResolving(String
table) {
+ "from orders\n"
+ "group by floor(rowtime to hour)")
.fails("Call to auxiliary group function 'TUMBLE_END' must have "
- + "matching call to group function 'TUMBLE' in GROUP BY clause");
+ + "matching call to group function '\\$TUMBLE' in GROUP BY
clause");
Review comment:
Yes I think it's a valid concern. Ideally we should start to deprecate GROUP
BY TUMBLE as table function TUMBLE is implemented. Maybe we can tolerate a bit
for now on this concern? Or we should have a pending table function TUMBLE
implementation to justify this PR and then merge both one by one?
I would be open to suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
