amaliujia commented on a change in pull request #1510: [CALCITE-3418] Grouped
Window Function TUMBLE should return "$TUMBLE"…
URL: https://github.com/apache/calcite/pull/1510#discussion_r339356409
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -10093,22 +10093,22 @@ private void checkCustomColumnResolving(String
table) {
+ "from orders\n"
+ "group by floor(rowtime to hour)")
.fails("Call to auxiliary group function 'TUMBLE_END' must have "
- + "matching call to group function 'TUMBLE' in GROUP BY clause");
+ + "matching call to group function '\\$TUMBLE' in GROUP BY
clause");
Review comment:
HI @jinxing64. #1481 added TUMBLE to parser so the syntax is still remain
the same. E.g. `GROUP BY TUMBLE(rowtime, interval '2' hour, time '00:12:00')`.
The decision in #1481 was still return `TUMBLE` as the operator name. And in
order to work on https://jira.apache.org/jira/browse/CALCITE-3340, it turns out
that we should return `$TUMBLE` as the operator name (at least it is a more
straightforward way). `$TUMBLE` will only appear when you call
Operator.`getName()` or `toString()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
